Apply options on missed keyring types #5404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinabell
requested review from
alessio,
alexanderbez,
fedekunze,
jackzampolin and
rigelrozanski
as code owners
fedekunze
approved these changes
Dec 13, 2019
Codecov Report
@@ Coverage Diff @@
## master #5404 +/- ##
=======================================
Coverage 54.56% 54.56%
=======================================
Files 311 311
Lines 18756 18756
=======================================
Hits 10235 10235
Misses 7742 7742
Partials 779 779
|
alessio
approved these changes
Dec 13, 2019
alessio
suggested changes
Dec 13, 2019
alessio
approved these changes
Dec 13, 2019
xiangjianmeng
pushed a commit
to xiangjianmeng/cosmos-sdk
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing options applied after changes from #5278. I apologize I was not thorough enough to test after the final update through the full flow. There was some logic changed just before the PR was merged in and after going through the complete flow of regenerating keys to test I noticed some cases were missed. I should have retested everything after each update, sorry.
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)